FIRSTMATE-35: Relaunching a worker breaks its PR merge monitoring #52

Merged

john merged 3 commits from fm/fm-relaunch-pr-poll into main 2026-10-24 04:59:20 +00:00

Conversation 0 Commits 3 Files changed 2 +27 -8

john commented 2026-10-24 03:55:00 +00:00

Owner

Copy link

Story: FIRSTMATE-35 - Relaunching a worker breaks its PR merge monitoring
Author: gpt-6-luna (medium reasoning effort) via Codex CLI

Summary

• Write relaunch transaction and trace context metadata before preserved PR identity fields so pr= remains the authenticated trailer.
• Extend the relaunch regression to verify PR metadata parses after relaunch and fails when the ordering fix is reverted.

Validation

• tests/fm-control.test.sh passed.
• tests/fm-pr-check-security.test.sh passed.
• bin/fm-lint.sh passed.
• tests/fm-control-relaunch.test.sh passed on unmodified main with scratch outside the checkout; the local run's later secondmate safety refusal was caused by scratch being inside the repository.
• No-mistakes completed as passed-with-skips on validated head 30383e77397a76cb617fb27f2f74f2e6e2f4d5f6; its PR and CI steps were skipped because the provider resolved as unknown. The pipeline confirmed the targeted regression passes and that the fix also moves trace context ahead of PR metadata.

**Story:** FIRSTMATE-35 - Relaunching a worker breaks its PR merge monitoring **Author:** gpt-6-luna (medium reasoning effort) via Codex CLI ## Summary - Write relaunch transaction and trace context metadata before preserved PR identity fields so `pr=` remains the authenticated trailer. - Extend the relaunch regression to verify PR metadata parses after relaunch and fails when the ordering fix is reverted. ## Validation - `tests/fm-control.test.sh` passed. - `tests/fm-pr-check-security.test.sh` passed. - `bin/fm-lint.sh` passed. - `tests/fm-control-relaunch.test.sh` passed on unmodified `main` with scratch outside the checkout; the local run's later secondmate safety refusal was caused by scratch being inside the repository. - No-mistakes completed as `passed-with-skips` on validated head `30383e77397a76cb617fb27f2f74f2e6e2f4d5f6`; its PR and CI steps were skipped because the provider resolved as unknown. The pipeline confirmed the targeted regression passes and that the fix also moves trace context ahead of PR metadata.

john added 3 commits 2026-10-24 03:55:00 +00:00

Keep relaunch metadata before PR identity f49712f701

no-mistakes(review): Insert relaunch traceparent before PR metadata trailer 64b33978fe

no-mistakes(document): Document PR identity trailer ordering in spawn meta writers 30383e7739

john merged commit 61a9c112e9 into main 2026-10-24 04:59:20 +00:00

john referenced this pull request from a commit 2026-10-24 04:59:21 +00:00

FIRSTMATE-35: Relaunching a worker breaks its PR merge monitoring (#52)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

john/firstmate!52

No description provided.